Allow OAuth 2.0 user defined file sources (w/Dropbox integration) #18272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
added
area/UI-UX
kind/feature
area/API
area/auth
jmchilton
force-pushed
the
oauth2_user_file_sources_dev
branch
from
2ba6a75 to
d8339fe
Compare
jmchilton
force-pushed
the
oauth2_user_file_sources_dev
branch
6 times, most recently
from
7ddf7db to
b02e537
Compare
jmchilton
force-pushed
the
oauth2_user_file_sources_dev
branch
3 times, most recently
from
bdb037e to
8a93354
Compare
jmchilton
force-pushed
the
oauth2_user_file_sources_dev
branch
from
8a93354 to
8df6893
Compare
|
This is very cool! Let me know when it's ready and I'd be happy to do some testing. |
jmchilton
force-pushed
the
oauth2_user_file_sources_dev
branch
2 times, most recently
from
b15652c to
62137df
Compare
jmchilton
force-pushed
the
oauth2_user_file_sources_dev
branch
10 times, most recently
from
b2033a4 to
cbbd223
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
itisAliRH
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Thank you @jmchilton, this looks great. I appreciate it!
I tested it, and it’s running perfectly. I made a few minor tweaks and will build on this to enhance the UI in future PRs.
mvdbeek
force-pushed
the
oauth2_user_file_sources_dev
branch
from
af3072d to
1e6704a
Compare
davelopez
force-pushed
the
oauth2_user_file_sources_dev
branch
from
1e6704a to
2d735af
Compare
- UI for detailed display of errors. - UI option to test configuration from management menu. - API + UI for checking configuration before upgrading to new version of template. - API + UI for checking configuration before updating current template's settings. - Add an option during update/upgrade to allow forcing the update even if configuration doesn't validate - I don't allow creation of invalid things, but if there are problems with an existing thing - admins and power users should have recourse. It is their data.
…ile redirecting to the file source provider in `FileSources/CreateInstance`
… and show errors in `CreateUserFileSource` Co-authored-by: David López <[email protected]>
davelopez
force-pushed
the
oauth2_user_file_sources_dev
branch
from
2d735af to
c905259
Compare
|
Looks like the integration tests failures are relevant, I'll take a look. |
davelopez
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
The remaining test failures are unrelated.
Thank you @jmchilton and @itisAliRH!
|
Wow - this is huge - thank you for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #18222 (only the last commit is relevant to this PR beyond that one currently).
This implements oauth2 client capabilities with the user defined file sources framework. There would be some work to integrate this with user defined object stores also but that would be pretty minimal given the code overlap/shared abstractions used on the client and server.
This works currently more or less but I want to make sure it works with Scope requesting clients and on a second service so I going to wait until I've integrated a Google Drive plugin and documented that before taking it out of Draft/WIP.
This work integrates an initial oauth2 enabled plugin for Dropbox including admin documentation for how to configure it and how build and configure a Dropbox app within Dropbox for a Galaxy instance.
Documentation Screenshot
Documentation Screenshot
Documentation Screenshot
For oauth2 services - the plugin status framework has been updated to reflect some additional information. Hopefully we can use it down the road to know when refresh tokens need to be re-requested and such though nothing beyond initial creation and typical use is implemented here so far:
How to test the changes?
(Select all options that apply)
http://localhost:8081/oauth2_callbackin my local testing with themake client-dev-serverproxy.License